@LucasXu0 please note that I translated web.signInAgreement including web.termOfUse, web.and and web.privacyPolicy inside of the translated text, as it isn't possible to translate the Text to German with the sentence ending on "[...]AppFlowys [Terms] [and] [Privacy Policy]". So the three other strings will be duplicated and the translation in Germany will look weird, as long as the strings are handled like this in AppFlowy.

And something should happen with this itemThree in the English translation. InLang automatically optimizes the translation and always removes it.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.27%. Comparing base (c122f0a) to head (3936e8c).
Report is 62 commits behind head on main.

@@            Coverage Diff             @@
##             main    #5722      +/-   ##
==========================================
- Coverage   86.74%   83.27%   -3.48%     
==========================================
  Files         217      214       -3     
  Lines        5032     5290     +258     
  Branches      831      863      +32     
==========================================
+ Hits         4365     4405      +40     
- Misses        561      795     +234     
+ Partials      106       90      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

And something should happen with this itemThree in the English translation. InLang automatically optimizes the translation and always removes it.

Because itemThree is empty, I should remove it. cc @Xazin

please note that I translated web.signInAgreement including web.termOfUse, web.and and web.privacyPolicy inside of the translated text

I want to confirm if you can translate it to German correctly with this format:

"signInAgreement": "By clicking "Continue" above, you confirm that
you have read, understood, and agreed to
AppFlowy's {} and {}",
"privacyPolicy": "Privacy Policy",
"termOfUse": "Terms",

the {} means the linked text and I'll fill it up with "privacyPolicy" and "termOfUse".

I want to confirm if you can translate it to German correctly with this format:

"signInAgreement": "By clicking "Continue" above, you confirm that
you have read, understood, and agreed to
AppFlowy's {} and {}",
"privacyPolicy": "Privacy Policy",
"termOfUse": "Terms",

the {} means the linked text and I'll fill it up with "privacyPolicy" and "termOfUse".

Yes, I would be able to translate it properly in this format.

@suntorytimed The way I mentioned doesn't work. If using the translation like that, it's unable to set the terms and privacy link.

          TextSpan(
            text: LocaleKeys.web_signInAgreement.tr(
              args: [
                LocaleKeys.web_termOfUse.tr(),
                LocaleKeys.web_privacyPolicy.tr(),
              ],
            ),
            style: const TextStyle(color: Colors.grey, fontSize: 12),
          ),

@LucasXu0 that's unfortunate. I will try to formulate the text different in the German translation without moving too far away from the original meaning. Will sound weird for a native speaker, but at least it won't have trailing strings.

Not ideal, but this should work. It basically refers to a list of "documents" that need to be read, understood and accepted and "AppFlowy's Privacy Policy and Terms" would be the one and only entry of the "list"

Does Commit messages lint / commitlint (pull_request) complain about Fix wrongfully removed itemThree not having a tag like chore:?

And something should happen with this itemThree in the English translation. InLang automatically optimizes the translation and always removes it.

Because itemThree is empty, I should remove it. cc @Xazin

It's removed in our plan+billing changes, but the PR won't be opened before Wednesday morning earliest.

rebased and hopefully fixed the commit message for the CI